fix(venv): preserve custom prompt when reusing existing venv#30
Merged
Conversation
This commit fixes an issue where custom prompts set during virtual environment creation were being overwritten when reusing an existing venv. The prompt update logic now only runs when a new venv is created or recreated. **Prompt preservation logic:** * Modified the prompt update condition in `src/main.rs` to check both `needs_create` and `!has_custom_prompt` before updating the prompt, ensuring that existing venvs with custom prompts (set via --prompt or --prefix) are left untouched when reused. * Added clarifying comments explaining that reusing an existing venv preserves the pyvenv.cfg file and any prompt configuration from the original creation.
benbenbang
enabled auto-merge (squash)
March 30, 2026 17:00
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where custom prompts set during virtual environment creation were being overwritten when reusing an existing venv. The prompt update logic now only runs when a new venv is created or recreated.
Prompt preservation logic:
src/main.rsto check bothneeds_createand!has_custom_promptbefore updating the prompt, ensuring that existing venvs with custom prompts (set via --prompt or --prefix) are left untouched when reused.